Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated lodash 4.17.12 to 4.17.19 #791

Merged
merged 5 commits into from
Jul 31, 2020
Merged

Updated lodash 4.17.12 to 4.17.19 #791

merged 5 commits into from
Jul 31, 2020

Conversation

bgaeddert
Copy link
Contributor

yarn audit --no-color --groups dependencies
yarn audit v1.22.4
0 vulnerabilities found - Packages audited: 120
✨ Done in 1.78s.

@bgaeddert bgaeddert requested review from blag, punkrokk and arm4b July 29, 2020 13:31
arm4b
arm4b reviewed Jul 30, 2020
View reviewed changes
.circleci/config.yml Outdated
@@ -71,7 +71,7 @@ jobs:
sudo chmod +x /usr/local/bin/docker-compose
- run:
name: Clone test containers
command: git clone --depth 1 https://github.com/StackStorm/st2-docker ~/st2-docker
command: git clone -b "DEPRECATED/all-in-one" --depth 1 https://github.com/StackStorm/st2-docker ~/st2-docker
Copy link
Member

@arm4b arm4b Jul 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This will also fix the existing builds in master branch due to st2-docker switching to new deployment model.

punkrokk
punkrokk suggested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@punkrokk punkrokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgaeddert will you please copy @blag's approach from here? StackStorm/st2chatops#156

@bgaeddert
Copy link
Contributor Author

@punkrokk CicleCi shell does not seem to be respecting the null coalescing operator :- and is returning the <nil> for ST2_DOCKER_BRANCH rather than resolving as empty and using the default.

# Use DEPRECATED/all-in-one for now, we'll have to circle back around
# and fix this to use the master branch
echo "Cloning ${ST2_DOCKER_BRANCH:-DEPRECATED/all-in-one} branch of st2-docker"
git clone --branch ${ST2_DOCKER_BRANCH:-DEPRECATED/all-in-one} --depth 1 ${ST2_TEST_ENVIRONMENT} ~/st2-docker
Cloning <nil> branch of st2-docker
Cloning into '/home/circleci/st2-docker'...
warning: Could not find remote branch <nil> to clone.
fatal: Remote branch <nil> not found in upstream origin

Exited with code exit status 128
CircleCI received exit code 128```

@punkrokk punkrokk added this to the 3.3.0 milestone Jul 31, 2020
@punkrokk punkrokk merged commit b3b7b62 into StackStorm:master Jul 31, 2020
@nmaludy nmaludy mentioned this pull request Oct 9, 2020
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

@punkrokk punkrokk punkrokk approved these changes

@blag blag Awaiting requested review from blag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bgaeddert @punkrokk @arm4b